Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10332 - add skip criteria for test that's flaky on non-posix #11666

Closed
wants to merge 1 commit into from

Conversation

eevelweezel
Copy link
Contributor

Scope and purpose

Fixes #10332

Add skip criteria for test that's flaky on non-posix systems, similar to other tests in the module.

Contributor Checklist:

This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.

Below is a non-exhaustive list (as a reminder):

  • The title of the PR should describe the changes and starts with the associated issue number, like “#9782 Remove twisted.news. #1234 Brief description”.
  • A release notes news fragment file was create in src/twisted/newsfragments/ (see: Release notes fragments docs.)
  • The automated tests were updated.
  • Once all checks are green, request a review by leaving a comment that contains exactly the string please review.
    Our bot will trigger the review process, by applying the pending review label
    and requesting a review from the Twisted dev team.

@adiroiban
Copy link
Member

I am not sure that always skipping a flaky test is the way to fix it :p

and I haven't seen that error lately in the CI?

Do you have an environment in which this tests fails often ?

Maybe it is worth investigating why it fails there... I am sure there is a bug somewhere.

@eevelweezel eevelweezel closed this Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix flaky test generated by warnings
2 participants