#10345 - Remove deprecated inspect.getargspec from sendmail tests. #11733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review |
adiroiban
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
Changes looks good and I think this can be merged.
Since we don't yet support/run test on Python 3.11 I would say that the PR is more about removing python3 deprecated code.
If you have time, it would be awesome if you could create a PR for #10343 and enable Python 3.11 in our GitHub Actions automated test suite.
| @@ -0,0 +1 @@ | |||
| Fix SendmailTests for python 3.11. | |||
There was a problem hiding this comment.
For .misc, you can leave the file empty as it will not be visible in the release note.
The content of this file should not be a commit message :)
We already have git for that.
Here we put all the "commit" information for people using Twisted.
adiroiban
changed the title
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jan 11, 2023
https://build.opensuse.org/request/show/1057659 by user dgarcia + dimstar_suse - Add py311-tests-compat.patch to fix tests with python 3.11 gh#twisted/twisted#11734 gh#twisted/twisted#11733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #10345
Replace usage of inspect.getargspec() with inspect.getfullargspec() for Python 3.11 compatibility.