#11738 portable gi obsolete

[glyph]

Scope and purpose

Fixes #11738

Contributor Checklist:

This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.

Below is a non-exhaustive list (as a reminder):

• The title of the PR should describe the changes and starts with the associated issue number, like “#9782 Remove twisted.news. #1234 Brief description”.
• A release notes news fragment file was create in src/twisted/newsfragments/ (see: Release notes fragments docs.)
• The automated tests were updated.
• Once all checks are green, request a review by leaving a comment that contains exactly the string please review.
  Our bot will trigger the review process, by applying the pending review label
  and requesting a review from the Twisted dev team.

[glyph]

io_add_watch has been supported with sockets on windows since 2016:

https://pygobject.readthedocs.io/en/latest/changelog.html?highlight=io_add_watch#id45

[glyph]

Sigh. The test failures are just codecov falling over again. I really want to get on a pure github actions workflow for coverage

[exarkun]

Sigh. The test failures are just codecov falling over again. I really want to get on a pure github actions workflow for coverage

I'm trying to observe this but I can't figure it out. Where do I look to see spurious codecov failures for this PR?

[adiroiban]

The failures can be seen here - https://github.com/twisted/twisted/actions/runs/3381705937/jobs/5615891650#step:13:38

The errors are generated while trying to upload the reports to Codecov "cloud".

[adiroiban]

With the tests green, I think we are good to go, assuming the release notes are updated as suggested by JP :)

Thanks!