Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11835 Add future annotations import to prevent runtime evaluation of type annotations. #11838

Merged
merged 3 commits into from Mar 28, 2023

Conversation

dreid
Copy link
Contributor

@dreid dreid commented Mar 28, 2023

Scope and purpose

Fixes #11835

This brings pydoctor docs build time on my machine down from 509s on trunk to just 244s.

Contributor Checklist:

This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.

Below is a non-exhaustive list (as a reminder):

  • The title of the PR should describe the changes and starts with the associated issue number, like “#9782 Remove twisted.news. #1234 Brief description”.
  • A release notes news fragment file was create in src/twisted/newsfragments/ (see: Release notes fragments docs.)
  • The automated tests were updated.
  • Once all checks are green, request a review by leaving a comment that contains exactly the string please review.
    Our bot will trigger the review process, by applying the pending review label
    and requesting a review from the Twisted dev team.

Copy link
Member

@glyph glyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should probably add a check that this is on every file at some point.

@glyph glyph enabled auto-merge March 28, 2023 21:47
@glyph glyph merged commit bacf4c8 into twisted:trunk Mar 28, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

twisted.web.template._flattenElement spends a significant amount of runtime in typing.py
3 participants