Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11952 use positional only for _ConcurrencyPrimitive run #11951

Conversation

graingert
Copy link
Member

@graingert graingert commented Sep 3, 2023

Scope and purpose

Fixes #11952

Comment on lines +2243 to 2244
/,
f: Callable[..., _SelfResultT],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would be better, but would be a breaking change

Suggested change
/,
f: Callable[..., _SelfResultT],
f: Callable[..., _SelfResultT],
/,

@graingert graingert changed the title use positional only for _ConcurrencyPrimitive run #11952 use positional only for _ConcurrencyPrimitive run Sep 3, 2023
@graingert graingert marked this pull request as ready for review September 3, 2023 09:55
@chevah-robot chevah-robot requested a review from a team September 3, 2023 09:55
Copy link
Member

@glyph glyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice to complete such an ancient TODO

@graingert graingert merged commit cbcb1f7 into twisted:trunk Sep 3, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix self_319AA2A8B18F4B8EA296D75F279EB07F thing for 3.8
3 participants