Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12113] type annotation updates #12115

Merged
merged 1 commit into from
Mar 15, 2024
Merged

[#12113] type annotation updates #12115

merged 1 commit into from
Mar 15, 2024

Conversation

glyph
Copy link
Member

@glyph glyph commented Mar 14, 2024

  • email.message.Message is more accurate now about get_payload's union
  • globaltrace attribute is now exposed

Scope and purpose

Fixes #12113

Add a few words about why this PR is needed and what is its scope.
If the associate ticket(s) fully explain the need you can just refer to it/them.

Add any comments about trade-offs (if any) made in this PR and the reasoning behind them.

Add mentions of things that are not covered here and are planed to be done in separate PRs.

Contributor Checklist:

This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.

Below is a non-exhaustive list (as a reminder):

  • The title of the PR should describe the changes and starts with the associated issue number, like “#9782 Remove twisted.news. #1234 Brief description”.
  • A release notes news fragment file was create in src/twisted/newsfragments/ (see: Release notes fragments docs.)
  • The automated tests were updated.
  • Once all checks are green, request a review by leaving a comment that contains exactly the string please review.
    Our bot will trigger the review process, by applying the pending review label
    and requesting a review from the Twisted dev team.

- email.message.Message is more accurate now about get_payload's union
- globaltrace attribute is now exposed
@glyph
Copy link
Member Author

glyph commented Mar 14, 2024

please review

@glyph
Copy link
Member Author

glyph commented Mar 14, 2024

@itamarst in particular

@glyph
Copy link
Member Author

glyph commented Mar 14, 2024

hell yeah, CI passed on the first try

@adiroiban adiroiban changed the title [12113] type annotation updates [#12113] type annotation updates Mar 14, 2024
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing trunk.

Thanks for the separate ticket.

I have updated the title of the PR to include the link to ticket number.

The macos tests might have passed now, but in the past they were failing quite often on first times, and sometimes even on second try :(
I still don't know how to fix them.

@glyph glyph merged commit cfdb069 into trunk Mar 15, 2024
24 checks passed
@glyph glyph deleted the 12113-mypy-typeshed-update branch March 15, 2024 00:04
@glyph
Copy link
Member Author

glyph commented Mar 15, 2024

The macos tests might have passed now, but in the past they were failing quite often on first times, and sometimes even on second try :(
I still don't know how to fix them.

Yeah I really don't know what's going on there. I no longer know what the bug is in the reactor itself, which seems like it should work to me now. And I never see these failures locally. I really wonder if it's something that github has done to their builders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mypy failing on trunk
3 participants