gtk3: remove check for DISPLAY variable #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appear to work well enough without that check. With Wayland becoming more pupolar, this check is in the way of running applications. Fixes: twisted#9904
As the code does not depend on this variable any more, testing for it does not make sense. There might be more logic to remove, since 4142aee introduced it.
muelli
force-pushed
the
9904-muelli-wayland
branch
from
f1032af
to
aa04af3
Compare
twm
approved these changes
Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appear to work well enough without that check.
With Wayland becoming more pupolar, this check is in
the way of running applications.
Fixes: #9904
Remove this section
Please have a look at our developer documentation before submitting your Pull Request.
Please note that the trac ticket, news fragment, and review submission portions of this process apply to all pull requests, no matter how small; if you don't do them, it's likely that nobody will even notice your PR needs a review.
Contributor Checklist:
reviewto the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.