Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the Twisted Coding Standard to refer to the Black code style #1394

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Change the Twisted Coding Standard to refer to the Black code style #1394

merged 2 commits into from
Sep 24, 2020

Conversation

rodrigc
Copy link
Contributor

@rodrigc rodrigc commented Sep 22, 2020 •
edited
Loading

Contributor Checklist:

@rodrigc
Copy link
Contributor Author

rodrigc commented Sep 22, 2020 •
edited
Loading

Changing the coding style guidelines for a codebase as old as Twisted is always......interesting. 😃

wsanchez
wsanchez approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@wsanchez wsanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the simplerness.

@rodrigc rodrigc merged commit c3e3f6a into trunk Sep 24, 2020
@rodrigc rodrigc deleted the 9957-rodrigc-coding-standard branch September 24, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsanchez wsanchez wsanchez approved these changes

@twm twm Awaiting requested review from twm

@glyph glyph Awaiting requested review from glyph

@hawkowl hawkowl Awaiting requested review from hawkowl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rodrigc @wsanchez