Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some more flake8 violations #1468

Merged
merged 6 commits into from Oct 26, 2020

Conversation

graingert
Copy link
Member

@graingert graingert commented Oct 26, 2020

Contributor Checklist:

Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

The use BaseException everywhere in this PR is a safe change.

But I feel that we are cheating the flake8 warning...as my understanding is that the flake8 is designed to make sure use a higher level exception and don't also catch SystemExit and other base exceptions.

But I think that this is moving into the right direction and in the future we will see more explicit exception handling

Thanks. Great work! Happy to see less flake8 things ignored.

@graingert graingert merged commit 0542c9d into twisted:trunk Oct 26, 2020
@graingert graingert deleted the fix-some-more-flake8-violations branch October 26, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants