Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10274: Fix the return type of listenSSL. #1672

Merged
merged 3 commits into from Mar 5, 2022
Merged

Conversation

clokep
Copy link
Contributor

@clokep clokep commented Nov 10, 2021

Scope and purpose

The return type of IReactorSSL.listenSSL is incorrect, it is specified as returning an int but actually returns IListeningPort. This was originally added in #1430.

Contributor Checklist:

  • The associated ticket in Trac is here: https://twistedmatrix.com/trac/ticket/10274
  • I ran tox -e lint to format my patch to meet the Twisted Coding Standard
  • I have created a newsfragment in src/twisted/newsfragments/ (see: News files)
  • The title of the PR starts with the associated Trac ticket number (without the # character).
  • I have updated the automated tests and checked that all checks for the PR are green.
  • I have submitted the associated Trac ticket for review by adding the word review to the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.
  • The merge commit will use the below format
    The first line is automatically generated by GitHub based on PR ID and branch name.
    The other lines generated by GitHub should be replaced.
Merge pull request #123 from twisted/4356-branch-name-with-trac-id

Author: <github_username>, <github_usernames_if_more_authors>
Reviewer: <github_username>, <github_username_if_more_reviewers>
Fixes: ticket:<trac_ticket_number>, ticket:<another_if_more_in_one_PR>

Long description providing a summary of these changes.
(as long as you wish)

@clokep
Copy link
Contributor Author

clokep commented Nov 10, 2021

I don't think there's tests to update for this, this would eventually have been caught via type hints being added to PosixReactorBase, I think.

Copy link
Contributor

@twm twm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

@twm twm added the needs-merge label Mar 5, 2022
@twm twm enabled auto-merge March 5, 2022 20:48
@twm twm merged commit be80342 into twisted:trunk Mar 5, 2022
@clokep clokep deleted the listenssl-type branch March 7, 2022 13:07
@clokep
Copy link
Contributor Author

clokep commented Mar 7, 2022

Thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants