Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10347: Remove the setEnv warning in manhole_ssh #1733

Merged
merged 1 commit into from May 25, 2022

Conversation

pmw
Copy link
Contributor

@pmw pmw commented May 25, 2022

Scope and purpose

On connection, the manhole gave a warning about the TerminalSession object not providing ISessionSetEnv interface. It should just ignore this silently, so the warning has been removed

Contributor Checklist:

  • The associated ticket in Trac is here: https://twistedmatrix.com/trac/ticket/10347
  • I ran tox -e lint to format my patch to meet the Twisted Coding Standard
  • I have created a newsfragment in src/twisted/newsfragments/ (see: News files)
  • The title of the PR starts with the associated Trac ticket number (without the # character).
  • I have updated the automated tests and checked that all checks for the PR are green.
  • I have submitted the associated Trac ticket for review by adding the word review to the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.
  • The merge commit will use the below format
    The first line is automatically generated by GitHub based on PR ID and branch name.
    The other lines generated by GitHub should be replaced.
Merge pull request #123 from twisted/4356-branch-name-with-trac-id

Author: pmw
Reviewer: <github_username>, <github_username_if_more_reviewers>
Fixes: ticket:10347

On connection, the manhole gave a warning about the TerminalSession
object not providing ISessionSetEnv interface. It should just ignore
this silently, so the warning has been removed.

Fixes: ticket:10347
Copy link
Member

@exarkun exarkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank. This looks good to me.

@exarkun exarkun merged commit 68a60b0 into twisted:trunk May 25, 2022
@pmw pmw deleted the 10347-pmw-remove-env-warning branch May 26, 2022 09:15
@pmw
Copy link
Contributor Author

pmw commented May 26, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants