Mark twisted.internet.defer.timeout as Deprecated #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 91.09% (diff: 100%)@@ trunk #654 diff @@
==========================================
Files 843 843
Lines 147019 147028 +9
Methods 0 0
Messages 0 0
Branches 12996 12996
==========================================
- Hits 134079 133942 -137
- Misses 10707 10844 +137
- Partials 2233 2242 +9
|
exarkun
approved these changes
Jan 18, 2017
| self.assertFailure(deferred, defer.TimeoutError) | ||
| warningsShown = self.flushWarnings([self.test_deprecatedTimeout]) | ||
| self.assertEqual(len(warningsShown), 1) | ||
| self.assertIdentical(warningsShown[0]['category'], DeprecationWarning) |
There was a problem hiding this comment.
I think assertIs is preferred. That's the stdlib unittest spelling for this assertion.
| @@ -160,6 +160,8 @@ def maybeDeferred(f, *args, **kw): | |||
|
|
|||
|
|
|||
|
|
|||
| @deprecated(Version('Twisted', 16, 8, 0), | |||
There was a problem hiding this comment.
Presumably this will be a 17.x.y now but I'm not sure what the current system for picking such numbers is, nor how one predicts this in advance. I heard some folks talking about Version("Twisted", "NEXT", 0, 0)? Maybe that was a joke of some sort though.
Probably at minimum bump this to some 17.x.y guess.
|
@hawkowl what is the next version number of Twisted going to be, so I can make sure this patch has the right one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://twistedmatrix.com/trac/ticket/8971