9243 westfeld add deployment docs pip #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a howto to use setuptools to package twisted applications for easy deployment using pip.
exarkun
previously requested changes
Aug 26, 2017
twm
requested changes
Mar 15, 2020
There was a problem hiding this comment.
Thanks for this! There are still a few things that must be addressed before we can merge, however.
I noted a serious issue with the example setup.py — I don't think it actually works as written.
The rest of the comments are minor. In addition to those I noted inline, "Python" should really be capitalized everywhere it appears in prose (including the news fragment).
Thanks for contributing to Twisted!
* Add a howto to use setuptools to package twisted applications for easy deployment using pip.
…stfeld/twisted into 9243-westfeld-add-deployment-docs-pip
twm
approved these changes
Jul 19, 2020
|
Thanks for finally accepting the PR. It took 3 years, but finally it worked out.
I still think that improving the docs is an important issue and I learned that outlining changes in the mailing list before writing a PR is the better way to go.
… Am 19.07.2020 um 07:53 schrieb Tom Most ***@***.***>:
Merged #852 into trunk.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://twistedmatrix.com/trac/ticket/9243