Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow UTF-8 characters (non-ASCII) in From: and To: fields in e-mail headers (RFC 6531) #867

Closed
wants to merge 58 commits into from
Closed

Allow UTF-8 characters (non-ASCII) in From: and To: fields in e-mail headers (RFC 6531) #867

wants to merge 58 commits into from

Commits on Aug 12, 2017

  1. Add testcase with non-ASCII characters in addresses.

    @rodrigc
    rodrigc committed Aug 12, 2017
    Copy the full SHA
    e2e0f0b View commit details
    Browse the repository at this point in the history

  2. Encode addresses with UTF-8, to comply with RFC 6531.

    @rodrigc
    rodrigc committed Aug 12, 2017
    Copy the full SHA
    e4d5c7d View commit details
    Browse the repository at this point in the history

  3. Add newsfragment

    @rodrigc
    rodrigc committed Aug 12, 2017
    Copy the full SHA
    ac928a5 View commit details
    Browse the repository at this point in the history

  4. Add utf-8 encoding, since we have non-ascii characters in this file

    @rodrigc
    rodrigc committed Aug 12, 2017
    Copy the full SHA
    f080926 View commit details
    Browse the repository at this point in the history

  5. Use utf-8 encoding, for RFC 6531.

    @rodrigc
    rodrigc committed Aug 12, 2017
    Copy the full SHA
    a5fa10a View commit details
    Browse the repository at this point in the history

  6. Fix whitespace

    @rodrigc
    rodrigc committed Aug 12, 2017
    Copy the full SHA
    c06b3f7 View commit details
    Browse the repository at this point in the history

  7. Expand regexp to support utf-8 characters, as specified in RFC 6532. 

    See the atext regexp in:
https://tools.ietf.org/html/draft-seantek-mail-regexen-00#section-3.1.1

for an example.
    @rodrigc
    rodrigc committed Aug 12, 2017
    Copy the full SHA
    df333a3 View commit details
    Browse the repository at this point in the history

  8. Handle None case

    @rodrigc
    rodrigc committed Aug 12, 2017
    Copy the full SHA
    e53917a View commit details
    Browse the repository at this point in the history

  9. Replace filter() with list comprehension.

    @rodrigc
    rodrigc committed Aug 12, 2017
    Copy the full SHA
    2ca7625 View commit details
    Browse the repository at this point in the history

  10. Fix bytes vs. unicode issues

    @rodrigc
    rodrigc committed Aug 12, 2017
    Copy the full SHA
    2edd62f View commit details
    Browse the repository at this point in the history

  11. Make sure fromEmail and toEmail are encoded as bytes

    @rodrigc
    rodrigc committed Aug 12, 2017
    Copy the full SHA
    16ad326 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2017

  1. Add testcase with non-ASCII characters in addresses.

    @rodrigc
    rodrigc committed Aug 16, 2017
    Copy the full SHA
    755ad6d View commit details
    Browse the repository at this point in the history

  2. Encode addresses with UTF-8, to comply with RFC 6531.

    @rodrigc
    rodrigc committed Aug 16, 2017
    Copy the full SHA
    63517bd View commit details
    Browse the repository at this point in the history

  3. Add newsfragment

    @rodrigc
    rodrigc committed Aug 16, 2017
    Copy the full SHA
    c108c23 View commit details
    Browse the repository at this point in the history

  4. Add utf-8 encoding, since we have non-ascii characters in this file

    @rodrigc
    rodrigc committed Aug 16, 2017
    Copy the full SHA
    c8dc5d6 View commit details
    Browse the repository at this point in the history

  5. Use utf-8 encoding, for RFC 6531.

    @rodrigc
    rodrigc committed Aug 16, 2017
    Copy the full SHA
    46ed732 View commit details
    Browse the repository at this point in the history

  6. Fix whitespace

    @rodrigc
    rodrigc committed Aug 16, 2017
    Copy the full SHA
    abb7cbe View commit details
    Browse the repository at this point in the history

  7. Expand regexp to support utf-8 characters, as specified in RFC 6532. 

    See the atext regexp in:
https://tools.ietf.org/html/draft-seantek-mail-regexen-00#section-3.1.1

for an example.
    @rodrigc
    rodrigc committed Aug 16, 2017
    Copy the full SHA
    4f49029 View commit details
    Browse the repository at this point in the history

  8. Handle None case

    @rodrigc
    rodrigc committed Aug 16, 2017
    Copy the full SHA
    319a507 View commit details
    Browse the repository at this point in the history

  9. Replace filter() with list comprehension.

    @rodrigc
    rodrigc committed Aug 16, 2017
    Copy the full SHA
    5b8fb50 View commit details
    Browse the repository at this point in the history

  10. Fix bytes vs. unicode issues

    @rodrigc
    rodrigc committed Aug 16, 2017
    Copy the full SHA
    bcdf4ed View commit details
    Browse the repository at this point in the history

  11. Make sure fromEmail and toEmail are encoded as bytes

    @rodrigc
    rodrigc committed Aug 16, 2017
    Copy the full SHA
    18bed21 View commit details
    Browse the repository at this point in the history

  12. Replace RFC 2821 with RFC 6531.

    @rodrigc
    rodrigc committed Aug 16, 2017
    Copy the full SHA
    9f817ac View commit details
    Browse the repository at this point in the history

  13. Fix imports

    @rodrigc
    rodrigc committed Aug 16, 2017
    Copy the full SHA
    f45784d View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2017

  1. Add comments explaining where regexp comes from.

    @rodrigc
    rodrigc committed Aug 18, 2017
    Copy the full SHA
    5802501 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' into 9250-rodrigc-mail

    @rodrigc
    rodrigc committed Aug 18, 2017
    Copy the full SHA
    99d0736 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2017

  1. Fix test names

    @rodrigc
    rodrigc committed Sep 5, 2017
    Copy the full SHA
    f224e82 View commit details
    Browse the repository at this point in the history

  2. Fix bytes/unicode issue

    @rodrigc
    rodrigc committed Sep 5, 2017
    Copy the full SHA
    531a592 View commit details
    Browse the repository at this point in the history

  3. dequotebs should not be bytes

    @rodrigc
    rodrigc committed Sep 5, 2017
    Copy the full SHA
    af4abd8 View commit details
    Browse the repository at this point in the history

  4. Add tests for parsing addresses

    @rodrigc
    rodrigc committed Sep 5, 2017
    Copy the full SHA
    aabd688 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'trunk' into 9250-rodrigc-mail

    @rodrigc
    rodrigc committed Sep 5, 2017
    Copy the full SHA
    2e3aad3 View commit details
    Browse the repository at this point in the history

  6. Merge branch '9250-rodrigc-mail' of https://github.com/twisted/twisted … 

    …into 9250-rodrigc-mail
    @rodrigc
    rodrigc committed Sep 5, 2017
    Copy the full SHA
    8809561 View commit details
    Browse the repository at this point in the history

  7. email.utils.parseaddr() returns ('', '') when it fails to parse, 

    not (None, None)
    @rodrigc
    rodrigc committed Sep 5, 2017
    Copy the full SHA
    159e861 View commit details
    Browse the repository at this point in the history

  8. Fix unicode/bytes encoding issue

    @rodrigc
    rodrigc committed Sep 5, 2017
    Copy the full SHA
    d6334c2 View commit details
    Browse the repository at this point in the history

  9. Add quoteaddr testcase

    @rodrigc
    rodrigc committed Sep 5, 2017
    Copy the full SHA
    2cc0669 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2017

  1. Merge branch 'trunk' into 9250-rodrigc-mail

    @rodrigc
    rodrigc committed Sep 6, 2017
    Copy the full SHA
    a8f654d View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2017

  1. Merge branch 'trunk' into 9250-rodrigc-mail

    @rodrigc
    rodrigc committed Sep 7, 2017
    Copy the full SHA
    418060e View commit details
    Browse the repository at this point in the history

  2. Advertise SMTPUTF8 option in the server for RFC 6531 support.

    @rodrigc
    rodrigc committed Sep 7, 2017
    Copy the full SHA
    658e364 View commit details
    Browse the repository at this point in the history

  3. Iterate over dictionary in sorted order

    @rodrigc
    rodrigc committed Sep 7, 2017
    Copy the full SHA
    701c722 View commit details
    Browse the repository at this point in the history

  4. Add encoding

    @rodrigc
    rodrigc committed Sep 7, 2017
    Copy the full SHA
    e2857e1 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2017

  1. By default in the SMTPSenderFactory, encode addresses with ascii, 

    and in ESMTPSenderFactory, encode addresses with utf-8
    @rodrigc
    rodrigc committed Sep 9, 2017
    Copy the full SHA
    29be470 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2017

  1. Replace nativeString(), networkString() with encode()/decode() with U… 

    …TF-8.
    @rodrigc
    rodrigc committed Sep 10, 2017
    Copy the full SHA
    1d3eef7 View commit details
    Browse the repository at this point in the history

  2. In SMTPClient, use "ascii" as default encoding, and in ESMTPClient us… 

    …e "utf-8"
    @rodrigc
    rodrigc committed Sep 10, 2017
    Copy the full SHA
    1d8a759 View commit details
    Browse the repository at this point in the history

  3. In ESMTPClient, if there is no SMTPUTF8 option on server, fall back t… 

    …o ascii encoding
    @rodrigc
    rodrigc committed Sep 10, 2017
    Copy the full SHA
    b0e5434 View commit details
    Browse the repository at this point in the history

  4. res needs to be bytes

    @rodrigc
    rodrigc committed Sep 10, 2017
    Copy the full SHA
    4ef1cfc View commit details
    Browse the repository at this point in the history

  5. When we are sending lines, if try to send lines which don't fall 

    within the encoding specified by self._encoding, raise an error.
    @rodrigc
    rodrigc committed Sep 10, 2017
    Copy the full SHA
    f9ef38c View commit details
    Browse the repository at this point in the history

  6. Add test for SMTPUTF8 option

    @rodrigc
    rodrigc committed Sep 10, 2017
    Copy the full SHA
    bcd666b View commit details
    Browse the repository at this point in the history

  7. Use unicode() to get consistent behavior on Python 2 and 3

    @rodrigc
    rodrigc committed Sep 10, 2017
    Copy the full SHA
    cc771a4 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'trunk' into 9250-rodrigc-mail

    @rodrigc
    rodrigc committed Sep 10, 2017
    Copy the full SHA
    1a130c9 View commit details
    Browse the repository at this point in the history

  9. Add more tests

    @rodrigc
    rodrigc committed Sep 10, 2017
    Copy the full SHA
    8fe39bf View commit details
    Browse the repository at this point in the history

  10. Add test

    @rodrigc
    rodrigc committed Sep 10, 2017
    Copy the full SHA
    cad6530 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2017

  1. Merge branch 'trunk' into 9250-rodrigc-mail

    @rodrigc
    rodrigc committed Sep 17, 2017
    Copy the full SHA
    e9fecec View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2017

  1. Add an encoding argument to quoteaddr

    @rodrigc
    rodrigc committed Sep 19, 2017
    Copy the full SHA
    fec7201 View commit details
    Browse the repository at this point in the history

  2. Use self._encoding

    @rodrigc
    rodrigc committed Sep 19, 2017
    Copy the full SHA
    3f37a17 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2017

  1. Merge branch 'trunk' into 9250-rodrigc-mail

    @rodrigc
    rodrigc committed Sep 23, 2017
    Copy the full SHA
    812635f View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2018

  1. Merge branch 'trunk' into 9250-rodrigc-mail

    @rodrigc
    rodrigc committed Mar 22, 2018
    Copy the full SHA
    2c0eb08 View commit details
    Browse the repository at this point in the history

  2. Fix pycodestyle errors

    @rodrigc
    rodrigc committed Mar 22, 2018
    Copy the full SHA
    a7f20f8 View commit details
    Browse the repository at this point in the history

  3. Fix pycodestyle error about invalid escaped character

    @rodrigc
    rodrigc committed Mar 22, 2018
    Copy the full SHA
    73e98a9 View commit details
    Browse the repository at this point in the history