Comments containing \r \n \t etc shouldn't report an error. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the actual comment is and the errors are |
adiroiban
changed the title
# ' shouldn't report an error.
|
Please take a look at latest patch. I have no idea why strings were removed from the comments. I have removed that code and tried to come up with other examples. Thanks! |
|
This looks fine to me, but I guess now that I've merged some other things, we need to merge master back in. |
|
Ok. Merged and resolved conflicts. |
|
This was waiting review for a long time :( |
adiroiban
added a commit
that referenced
this pull request
Oct 20, 2015
Comments containing \r \n \t etc shouldn't report an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following comment shouldn't be considered an error.
'\r\n' is the default, but we set it just to be explicit in this test.
Imported from Launchpad using lp2gh.