Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean code of pyflakes warnings #74

Merged
merged 6 commits into from
Sep 29, 2014
Merged

Clean code of pyflakes warnings #74

merged 6 commits into from
Sep 29, 2014

Conversation

adiroiban
Copy link
Member

This is to fix #67

I have clean all code, excepting the functional test which are broken by design.

I have create a dedicated pyflakes runner which excepts functional tests.

Another option is to move those files outside of twistedchecker

I will try to send a patch upstream to pyflakes to allow excluding files as a similar exception is required for twisted.

Thanks!

@glyph
Copy link
Member

glyph commented Sep 29, 2014

Can you put a commit on here so that travis will pick it up and tell us about build results?

@adiroiban
Copy link
Member Author

I have updated the travis.yml to also run pyflakes for each commit....

I have also updated pip install to add the --upgrade flag. In this way pip will pin version specified in setup.py install_requires

in the future, I hope that we can run twistedchecker to check twistedchecker codebase...

@glyph
Copy link
Member

glyph commented Sep 29, 2014

Thanks for the update. Awesome!

glyph added a commit that referenced this pull request Sep 29, 2014
Clean code of pyflakes warnings
@glyph glyph merged commit 9009ea1 into twisted:master Sep 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean pyflakes code
2 participants