__version__ is not a violation of the Twisted naming convention

[adiroiban]

This twistedchecker warning is invalid:

C0103:114,8:DummyOpenSSL.__init__: Invalid name "__version__" (should match ((([a-z_])|([a-z]+_[a-z]))[a-zA-Z0-9]+)$)

[adiroiban]

@exarkun version is an exception from the rule or there is a problem with the regex for names?

Thanks!

[exarkun]

__version__ is an example of a convention for naming certain things that's not disallowed by the coding standard.

It's a standard Python idiom to have package.__version__. Twisted should do this. It shouldn't be a twistedchecker error to define such a name.

Apart from that, DummyOpenSSL is a fake for a third-party library. Twisted can't do anything about the naming convention of third-party libraries. If the code were self.some_variable = value, this actually wouldn't conform to Twisted's naming convention but it would still be how the code must be written - if the third-party library dictates this.

[adiroiban]

thanks... I assume that all these "errors" came from pylint .... I stopped using pylint a long time ago as it was too pedantic... maybe we should remove pylint from pychecker and only build extra things around pyflakes..

[adiroiban]

Please take a look at latest changes.

I have merged to pass/fail tests for attribute names into a single test as I find it easier to follow good/bad examples.

Thanks!

[glyph]

Looks like this needs a merge, but is otherwise fine.

[adiroiban]

Thanks for the review. Please check latest changes.

needs-review