Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing minimum/supported twisted versions. #134

Closed
jvanasco opened this issue Oct 7, 2015 · 6 comments
Closed

missing minimum/supported twisted versions. #134

jvanasco opened this issue Oct 7, 2015 · 6 comments

Comments

@jvanasco
Copy link

jvanasco commented Oct 7, 2015

The package requires twisted, but does not specify a minimum version or the known target/working version.

@psi29a
Copy link
Contributor

psi29a commented Oct 8, 2015

Thanks for raising this, I made a pull request to fix it.

pymongo>=3.0
txmongo>=14.0

#136

Can you help validate this?

Technically, lower twisted versions should work... but only for python 2.7, not 3.

@jvanasco
Copy link
Author

jvanasco commented Oct 8, 2015

If i can spare some cycles, sure. I've got all our machines running simulations in prep for a large data migration (moving our read-only archive of searchindex snapshots from postgres to mongo via twisted for the wiredtiger compression!)

Everything works on "current", and I think its safe to peg minimums to that. The big issue I encountered was that I'm used to packages updating components, and a few machines had older twisteds+mongos.

This should technically work on all mongodb versions, with the exception of some "newer" functions. for example "aggregate" started around 2.2 (so epic failures if you're running 2.0!)

I can tell you that I loosely recall: (python 2.7.5)
• the example worked on pymongo 2.6 and current twisted. aggregate wasn't introduced until 2.2, and that caused a lot of issues. we could update to 2.6 on this architecture.
• Most tests passed under twisted 13.2, a few didn't. I think more tests passed on 15 than 13.

@psi29a
Copy link
Contributor

psi29a commented Oct 8, 2015

In order to hold to our self-imposed mandate of 1:1 with PyMongo, we've had to make some sacrifices with older versions of PyMongo and Python. While most things will still work with 2.6, we only make guarantees with 2.7 and 3.0 so with that: caveat emptor.

Twisted is a bit more tricky, as you said. We make use of Twisted's compat library to bridge 2.x and 3.0, but that is mostly in our test cases. We originally had Tox handling twisted back to 13.0 but with the push for 3.0 support, we had to back off to >=14.0

I wish you success in your postgres2mongodb migration. :) WT is great stuff to be sure, I'm just worried about the rest surrounding it. ;)

@jvanasco
Copy link
Author

jvanasco commented Oct 9, 2015

This definitely needs >=14. I tried on 13 when I had a moment, and it failed.

We're using Mongo for a data archive, so not worried too much. it just needs to write and hopefully not corrupt if we ever have to read.

@IlyaSkriblovsky
Copy link
Contributor

Is this issue still relevant? Seems like minimum twisted version is now specified in setup.py as 14.0.0.

@psi29a
Copy link
Contributor

psi29a commented Apr 19, 2016

I think so. We have a simplified setup.py.as a result.

@psi29a psi29a closed this as completed Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants