Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port hough circle example from OpenCV 4.9.0 #547

Merged

Conversation

jddj137
Copy link

@jddj137 jddj137 commented Feb 26, 2024

Port of https://github.com/opencv/opencv/blob/4.7.0/samples/cpp/tutorial_code/ImgTrans/HoughCircle_Demo.cpp, based on the examples/hough_lines.rs port of the HoughLines_Demo.cpp. Added examples/data directory with sample image from https://github.com/opencv/opencv/tree/4.9.0/samples/data to visually verify the port was working as expected and allow users to run the example.

@twistedfall
Copy link
Owner

Thanks a lot for the contribution! Can you please fix a couple of things before we merge this?

  1. The link to the cpp example is 404, the actual link is https://github.com/opencv/opencv/blob/4.7.0/samples/cpp/tutorial_code/ImgTrans/HoughCircle_Demo.cpp (Circle is singular). Maybe also rename the name of the example to also be hough_circle.
  2. For canny_threshold and accumulator_threshold I think it's better to use AtomicI32, it should be way lighter than a Mutex.

@twistedfall twistedfall self-requested a review February 26, 2024 07:56
@jddj137 jddj137 changed the title Port hough circles example from OpenCV 4.9.0 Port hough circle example from OpenCV 4.9.0 Feb 26, 2024
@twistedfall twistedfall merged commit 60d0804 into twistedfall:master Feb 27, 2024
14 checks passed
@twistedfall
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants