Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update dependencies & address ws security vulnerabilities #66

Merged
merged 2 commits into from
Apr 18, 2018

Conversation

embiem
Copy link
Collaborator

@embiem embiem commented Apr 14, 2018

Proposed changes

Updates out-of-date deps (without breaking anything) & fix all security vulnerabilities found by snyk & nsp.

Additionally, this PR removes the request dependency, as we were actually not using it.

Types of changes

What types of changes does your code introduce to TwitchJS?

  • Chore (change that does not fix an issue or add functionality, but improves TwitchJS in some other way)

Issue #65

Please see referenced issue for further details.

This PR just updates the minimum. We should still think about upgrading to a current ws release (which is currently 4 major version ahead of what twitch-js uses).

Copy link
Member

@marcandrews marcandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🥇

@marcandrews marcandrews changed the title update out-of-date deps & fix security vulnerabilities Chore: update dependencies & address ws security vulnerabilities Apr 15, 2018
@marcandrews
Copy link
Member

@mBeierl Any updates on this PR? Do you still need to test or make changes? If not, please update your branch and merge.

@embiem embiem merged commit beb4182 into master Apr 18, 2018
@embiem embiem deleted the chore/updateDeps branch April 18, 2018 20:34
@lock
Copy link

lock bot commented Jun 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants