Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug: It seems that multiple chat-tags map to the EMOTE ChannelState #65

Closed
4 tasks done
SomniumPrime opened this issue Mar 23, 2019 · 1 comment
Closed
4 tasks done

Comments

@SomniumPrime
Copy link
Contributor

Prerequisites

Description

Possible bug: It seems that multiple chat-tags map to the EMOTE ChannelState
In:
IRCEventHandler.onChannelState

case "emote-only":
    states.put(ChannelStateEvent.ChannelState.EMOTE, v.equals("1"));

case "r9k":
    states.put(ChannelStateEvent.ChannelState.EMOTE, v.equals("1"));

case "subs-only":
    states.put(ChannelStateEvent.ChannelState.EMOTE, v.equals("1"));

Solutions

Should these have been ChannelState.R9K and ChannelState.SUBSCRIBERS respectively?

@PhilippHeuer
Copy link
Member

You'r right - this was a mistake, thanks for creating the issue. Is fixed in develop in will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants