fix: register jackson modules despite exotic class loaders #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites for Code Changes
Issues Fixed
Instant
s needed to be deserialized from JSON, despite properly shading their plugin jar to include jackson and the jsr310 module. The custom PluginClassLoader used in this context likely is not compatible withObjectMapper#findAndRegisterModules
Changes Proposed
Primary
ParameterNamesModule
andJavaTimeModule
(so we are also shifting off of the deprecatedJSR310Module
with this PR) inTypeConvert
, instead of relying uponfindAndRegisterModules
TypeConvert
'sObjectMapper
wherever possibleSecondary