Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: migration to twitch4j.github.io #228

Merged
merged 3 commits into from Dec 20, 2020

Conversation

stachu540
Copy link
Contributor

@stachu540 stachu540 commented Nov 10, 2020

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Changes Proposed

Additional Information

Documentation migration has been completed. Only documentation in develop/master branch is leftover before v1.2.0 - I think I have done in time, maybe before deadline (which not exist yet 馃槃).

Closing #225

@stachu540 stachu540 marked this pull request as ready for review November 10, 2020 20:22
@stachu540
Copy link
Contributor Author

stachu540 commented Nov 30, 2020

Cause #220 are violate migration, files in this PR will be removed and must be updated into twitch4/twitch4j.github.io repository after migration.

Copy link
Member

@PhilippHeuer PhilippHeuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the link to the new documentation page 矛n the README.md?

@stachu540
Copy link
Contributor Author

Up you go. Also I made logo linked into main page.

@stachu540
Copy link
Contributor Author

stachu540 commented Dec 19, 2020

Cannot resolve this conflicts after #220

TL;DR those files has been transfered to new website, and they are already available to the public.

@PhilippHeuer PhilippHeuer merged commit 433873f into twitch4j:develop Dec 20, 2020
@stachu540 stachu540 deleted the docs/migration branch December 20, 2020 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants