build: shadow jar - all deps in one jar #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jar with "shaded" classifier
2 tasks
PhilippHeuer
requested changes
Dec 22, 2020
There was a problem hiding this comment.
Should we relocate all packages to avoid conflicts with other dependencies and also with ourselves? (ie. to allow ppl to use the shaded TwitchChat 1.0 together with shaded TwitchPubSub 1.1 as single modules)
We would just need to use a unique prefix for each module.
stachu540
commented
Dec 22, 2020
Co-authored-by: Damian Staszewski <359222+stachu540@users.noreply.github.com>
PhilippHeuer
approved these changes
Jan 4, 2021
|
#226 Closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites for Code Changes
Changes Proposed
com.github.johnrengelman.shadow- Closes FatJar in Maven repo #226Additional Information
In #226 where providing this plugin and applying
shadedword intoarchiveClassifierforshadowJartask, will automatically adds intoMavenPublication.All those changes are be tested before the pull request.