Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: set default kraken headers (accept, content-type) using interceptor #257

Merged
merged 3 commits into from Jan 20, 2021
Merged

refactor: set default kraken headers (accept, content-type) using interceptor #257

merged 3 commits into from Jan 20, 2021

Conversation

PhilippHeuer
Copy link
Member

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Changes Proposed

  • adds a interceptor for kraken api requests that:
    • sets the accept header application/vnd.twitchtv.v5+json for all requests
    • sets the content-type header for PUT,PATCH,POST requests if not set in the TwitchKraken interface
  • bumps the t4j user-agent to Twitch4j/1.2.0 (next release version)

Additional Information

@PhilippHeuer PhilippHeuer merged commit d68e404 into develop Jan 20, 2021
@PhilippHeuer PhilippHeuer deleted the feature/kraken-common-headers branch January 20, 2021 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iProdigy iProdigy iProdigy approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PhilippHeuer @iProdigy