Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: yield user on enable client helper event listener #277

Merged
merged 2 commits into from Feb 17, 2021

Conversation

iProdigy
Copy link
Member

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Changes Proposed

Instead of simple void functions, these enable methods now provide the User on success (which is useful for caching properties like the profile image url to be used in discord embeds)

  • enableStreamEventListener(String) => User
  • enableStreamEventListener(Iterable<String>) => Collection<User>
  • enableFollowEventListener(String) => User
  • enableFollowEventListener(Iterable<String>) => Collection<User>

Also:

  • Removed 10k limit on channelInformation
  • Include channel info in FollowEvent#toString
  • Don't invalidate entries in channelInformation cache if the channel was removed from one event listener but is still relevant for the other event listener

@iProdigy iProdigy merged commit 21893dd into develop Feb 17, 2021
@iProdigy iProdigy deleted the refactor/client-helper-enable-user branch February 17, 2021 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants