Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cheer badge to chat permissions #318

Merged
merged 1 commit into from Apr 18, 2021
Merged

feat: add cheer badge to chat permissions #318

merged 1 commit into from Apr 18, 2021

Conversation

iProdigy
Copy link
Member

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Changes Proposed

  • Add CommandPermission.BITS_CHEERER (and associated parsing logic in TwitchUtils)
  • Add IRCMessageEvent#getCheererTier (I'm not in love with this method name so we can change it if you have any ideas)
  • Ensure CommandPermission.PRIME_TURBO is present for turbo users
  • Small code formatting changes in TwitchUtils

@PhilippHeuer
Copy link
Member

The name IRCMessageEvent#getCheererTier is fine as it fits with CommandPermission.BITS_CHEERER.

@iProdigy iProdigy merged commit d5cf11a into develop Apr 18, 2021
@iProdigy iProdigy deleted the feature/chat-bits-badge branch April 18, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer PhilippHeuer approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iProdigy @PhilippHeuer