Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove lockedAt in predictionEnd / rename locksAt to lockedAt in predictionLock #342

Merged
merged 1 commit into from May 15, 2021
Merged

fix: remove lockedAt in predictionEnd / rename locksAt to lockedAt in predictionLock #342

merged 1 commit into from May 15, 2021

Conversation

PhilippHeuer
Copy link
Member

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Changes Proposed

This covers the changes deployed to eventsub today:

  • The eventsub channel.prediction.lock payload has a locked_at timestamp, rather than locks_at
  • The eventsub channel.prediction.end payload has had its locked_at field removed due to edge cases around predictions that were cancelled or resolved prematurely

Additional Information

See https://discord.com/channels/504015559252377601/776875921654546463/842867470343864351

@iProdigy
Copy link
Member

LGTM, cool with making these changes without depreciation since it's marked as beta & @Unofficial

@iProdigy iProdigy merged commit 9f65eb9 into develop May 15, 2021
@iProdigy iProdigy deleted the fix/eventsub-locked-at branch May 15, 2021 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iProdigy iProdigy iProdigy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PhilippHeuer @iProdigy