Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: promote channel.subscription.end eventsub to v1 #365

Merged
merged 1 commit into from
May 30, 2021
Merged

chore: promote channel.subscription.end eventsub to v1 #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions ...criptions/BetaChannelUnsubscribeType.java → ...criptions/ChannelSubscriptionEndType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,20 @@
import com.github.twitch4j.eventsub.events.ChannelUnsubscribeEvent;

/**
* The channel.unsubscribe subscription type sends a notification when a subscription to the specified channel expires.
* The channel.subscription.end subscription type sends a notification when a subscription to the specified channel expires.
* <p>
* Must have channel:read:subscriptions scope.
* <p>
* Unless otherwise noted, EventSub subscriptions that were released as a public beta will be available for 30 days after their v1 version is released. Subscriptions should be updated to v1 during this timeframe.
* Any active beta subscriptions beyond 30 days will be automatically deleted.
*/
public class BetaChannelUnsubscribeType implements SubscriptionType<ChannelUnsubscribeCondition, ChannelUnsubscribeCondition.ChannelUnsubscribeConditionBuilder<?, ?>, ChannelUnsubscribeEvent> {
public class ChannelSubscriptionEndType implements SubscriptionType<ChannelUnsubscribeCondition, ChannelUnsubscribeCondition.ChannelUnsubscribeConditionBuilder<?, ?>, ChannelUnsubscribeEvent> {

@Override
public String getName() {
return "channel.unsubscribe";
return "channel.subscription.end";
}

@Override
public String getVersion() {
return "beta";
return "1";
}

@Override
Expand Down
4 changes: 2 additions & 2 deletions ...ub-common/src/main/java/com/github/twitch4j/eventsub/subscriptions/SubscriptionTypes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public class SubscriptionTypes {
public final ChannelPointsCustomRewardUpdateType CHANNEL_POINTS_CUSTOM_REWARD_UPDATE;
public final ChannelRaidType CHANNEL_RAID;
public final ChannelSubscribeType CHANNEL_SUBSCRIBE;
@Unofficial public final BetaChannelUnsubscribeType BETA_CHANNEL_UNSUBSCRIBE;
public final ChannelSubscriptionEndType CHANNEL_SUBSCRIPTION_END;
public final ChannelUnbanType CHANNEL_UNBAN;
public final ChannelUpdateType CHANNEL_UPDATE;
public final HypeTrainBeginType HYPE_TRAIN_BEGIN;
Expand Down Expand Up @@ -61,7 +61,7 @@ public class SubscriptionTypes {
CHANNEL_POINTS_CUSTOM_REWARD_UPDATE = new ChannelPointsCustomRewardUpdateType(),
CHANNEL_RAID = new ChannelRaidType(),
CHANNEL_SUBSCRIBE = new ChannelSubscribeType(),
BETA_CHANNEL_UNSUBSCRIBE = new BetaChannelUnsubscribeType(),
CHANNEL_SUBSCRIPTION_END = new ChannelSubscriptionEndType(),
CHANNEL_UNBAN = new ChannelUnbanType(),
CHANNEL_UPDATE = new ChannelUpdateType(),
HYPE_TRAIN_BEGIN = new HypeTrainBeginType(),
Expand Down