Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve pubsub topic name matching #376

Merged
merged 4 commits into from
Jul 19, 2021
Merged

refactor: improve pubsub topic name matching #376

merged 4 commits into from
Jul 19, 2021

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Jun 4, 2021 •
edited
Loading

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Issues Fixed

Changes Proposed

  • Use String#split on the topic to identify parts instead of utilizing startsWith/(last)indexOf
  • Avoid writing auth_token to debug log on LISTEN
  • Fix javadoc generation of AutomodContentClassification.Category
  • Add is_anonymous field to ChannelBitsData

@iProdigy iProdigy merged commit 773de03 into develop Jul 19, 2021
@iProdigy iProdigy deleted the refactor/pubsub-topic-name-matching branch July 19, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer PhilippHeuer approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iProdigy @PhilippHeuer