Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: parse notice msgId to convenient enum #377

Merged
merged 2 commits into from Jun 10, 2021
Merged

feat: parse notice msgId to convenient enum #377

merged 2 commits into from Jun 10, 2021

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Jun 7, 2021

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Changes Proposed

  • Create NoticeTag enum and parse ChannelNoticeEvent#msgId into the enum

Additional Information

https://dev.twitch.tv/docs/irc/msg-id

@iProdigy iProdigy merged commit 7daf45e into develop Jun 10, 2021
@iProdigy iProdigy deleted the feature/chat-notice-enum branch June 10, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer PhilippHeuer approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iProdigy @PhilippHeuer