feat: add drop entitlement grant eventsub type #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites for Code Changes
Changes Proposed
drop.entitlement.grantv1 eventsub typeAdditional Information
The eventsub batching implementation in its current state is (somewhat) built off a trick and not flexible enough for batching to be idiosyncratically enabled/disabled for multiple subscriptions of a given type; instead, all subscriptions of a given type must strictly have batching enabled or disabled. Note: such batching control is not supported by Twitch anyways (at the moment — trying to get clarification on future plans, though)