Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: store emote id as string in sub events over pubsub #425

Merged
merged 1 commit into from Aug 29, 2021

Conversation

iProdigy
Copy link
Member

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Issues Fixed

com.fasterxml.jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `int` from String "emotesv2_01ad668a984f449ba9d950381638056a": not a valid `int` value

Changes Proposed

  • Make the emote id in pubsub commerce messages a string (in unbreaking fashion)
  • Unrelated: add more fields for unofficial sub gift events over pubsub

Additional Information

Thanks to Doc#4444 for reporting

@PhilippHeuer PhilippHeuer merged commit ea0d5c4 into develop Aug 29, 2021
@PhilippHeuer PhilippHeuer deleted the fix/pubsub-sub-msg-emote-id branch August 29, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants