Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parse new mod pubsub format for mod and vip actions #435

Merged
merged 1 commit into from Sep 26, 2021
Merged

fix: parse new mod pubsub format for mod and vip actions #435

merged 1 commit into from Sep 26, 2021

Conversation

iProdigy
Copy link
Member

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Issues Fixed

Changes Proposed

  • Fire ChatModerationEvent for alternative message format of mod/unmod/vip/unvip

Additional Information

More details: twitchdev/issues#218 (comment)

  • There are scenarios where no pubsub message is sent when we would expect one
  • There are scenarios where ChatModerationEvent will be fired more than once (because twitch can send both the traditional format and this new format)

@iProdigy iProdigy linked an issue Sep 19, 2021 that may be closed by this pull request
Mod/unmod events are not parsed in pubsub #431
Closed
2 tasks
@iProdigy iProdigy merged commit 8d3b5cc into develop Sep 26, 2021
@iProdigy iProdigy deleted the fix/pubsub-new-mod-actions branch September 26, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer PhilippHeuer approved these changes

Assignees
No one assigned
Labels
bug/minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mod/unmod events are not parsed in pubsub
2 participants
@iProdigy @PhilippHeuer