Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: special messages can prevent triggering a ChannelMessageEvent #513

Merged
merged 1 commit into from Jan 18, 2022

Conversation

PhilippHeuer
Copy link
Member

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Issues Fixed

user messages containing one of three special strings are able to circumvent parsing into a channel message event and could potentially bypass moderation features built with twitch4j.

Additional Information

Thanks to @SubSide for reporting the issue.

:req Invalid CAP command, :tmi.twitch.tv CAP * ACK :, and PING :tmi.twitch.tv


Co-authored-by: Sidd <iProdigy@users.noreply.github.com>
Co-authored-by: SubSide <SubSide@users.noreply.github.com>
@PhilippHeuer PhilippHeuer merged commit c81b6a2 into develop Jan 18, 2022
@PhilippHeuer PhilippHeuer deleted the fix/message-event-bypass branch January 19, 2022 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants