Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(chat): avoid duplicated tags parsing #792

Merged
merged 4 commits into from Jun 18, 2023
Merged

perf(chat): avoid duplicated tags parsing #792

merged 4 commits into from Jun 18, 2023

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Jun 18, 2023 •
edited

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Issues Fixed

  • If a tag value included =, the value would be truncated

Changes Proposed

  • Remove rawTags field (avoids calling parseTags twice)
  • Deprecate getRawTags (simply returns tags now)

Additional Information

The maps assigned to tags and rawTags were equal, despite rawTags having Object values (they were all strings)

@iProdigy iProdigy merged commit e1fe813 into develop Jun 18, 2023
@iProdigy iProdigy deleted the perf/duplicate-tags-parse branch June 18, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer PhilippHeuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iProdigy @PhilippHeuer