Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helix): avoid NPE from withClientId(null) #804

Merged
merged 1 commit into from Jul 1, 2023
Merged

fix(helix): avoid NPE from withClientId(null) #804

merged 1 commit into from Jul 1, 2023

Conversation

iProdigy
Copy link
Member

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Issues Fixed

  • NPE in TwitchHelixTokenManager caused by withClientId(null) from bad user code (or lack of a default client id in TwitchEventSocket)

Changes Proposed

  • Avoid stringifying a null client_id passed to helix

@iProdigy iProdigy merged commit 42d5bfc into develop Jul 1, 2023
@iProdigy iProdigy deleted the fix/helix-token-manager-null-client_id branch July 1, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer PhilippHeuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iProdigy @PhilippHeuer