Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow IEventSubSocket#register with null transport #815

Merged
merged 3 commits into from Jul 20, 2023

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Jul 19, 2023

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Issues Fixed

  • Allow eventsub subscriptions to be registered with null EventSubTransport (EventSubSubscription#setTransport in TwitchEventSocket#register was not reflected in SubscriptionWrapper)

Changes Proposed

  • SubscriptionWrapper should delegate getters to the held EventSubSubscription rather than copying the fields, which ensures any setters called on the underlying subscription are reflected in the wrapper (and reduces memory consumption)

@iProdigy iProdigy force-pushed the fix/eventsocket-register-transport-null branch from 7b90791 to 111d9c6 Compare July 19, 2023 15:18
@iProdigy iProdigy merged commit d57c52d into develop Jul 20, 2023
@iProdigy iProdigy deleted the fix/eventsocket-register-transport-null branch July 20, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants