Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clienthelper): reflect name changes in live events #828

Merged
merged 1 commit into from Aug 1, 2023
Merged

fix(clienthelper): reflect name changes in live events #828

merged 1 commit into from Aug 1, 2023

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Aug 1, 2023 •
edited

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Changes Proposed

  • Use the latest broadcaster login name in ChannelGoLiveEvent, ChannelGoOfflineEvent, ChannelChangeTitleEvent, ChannelChangeGameEvent, ChannelViewerCountUpdateEvent (in case the broadcaster changes their username while the application is running)

Additional Information

  • Stream#getUserLogin did not exist when this conditional branch was originally written
  • Same exact change cannot be made for clips / follow events since broadcaster login name is not exposed by Twitch in these endpoints
  • If user has client helper running stream listener for a channel alongside follow/clips listener, updated username will also apply to follow/clip events

@iProdigy iProdigy merged commit 1adf4ae into develop Aug 1, 2023
@iProdigy iProdigy deleted the chore/helper-live-channel-name branch August 1, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer PhilippHeuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iProdigy @PhilippHeuer