Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(helix): sync ratelimit bucket for void endpoints #848

Merged
merged 1 commit into from Sep 3, 2023

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Sep 3, 2023

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Issues Fixed

  • TwitchHelixRateLimitTracker was not updated with Ratelimit-Remaining header for HystrixCommand<Void> endpoints (technically not an issue unless a user has multiple TwitchHelix instances / is using the same token across multiple applications)

Changes Proposed

  • Enable decodeVoid for helix module

Additional Information

Enabled by #839 / https://togithub.com/OpenFeign/feign/pull/2131

@iProdigy iProdigy merged commit c5ddb91 into develop Sep 3, 2023
@iProdigy iProdigy deleted the chore/helix-decode-void branch September 3, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants