Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use helix default token for eventsocket pool #870

Merged
merged 1 commit into from Oct 19, 2023
Merged

feat: use helix default token for eventsocket pool #870

merged 1 commit into from Oct 19, 2023

Conversation

iProdigy
Copy link
Member

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Changes Proposed

  • defaultAuthToken in TwitchClient(Pool)Builder is now used by TwitchEventSocketPool if register is called without a credential

Additional Information

Improves consistency with TwitchSingleUserEventSocketPool & TwitchEventSocket

@iProdigy iProdigy merged commit a32b384 into develop Oct 19, 2023
@iProdigy iProdigy deleted the feature/client-eventsocket-token-default branch October 19, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer PhilippHeuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iProdigy @PhilippHeuer