Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helix): allow querying moderator status of multiple user ids #936

Merged
merged 1 commit into from Feb 19, 2024

Conversation

iProdigy
Copy link
Member

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Issues Fixed

  • TwitchHelix#getModerators would fail when passed more than one user ID to check moderator status (Twitch would complain about malformed query parameter)

Changes Proposed

  • Use repeated query param format for userIds in TwitchHelix#getModerators instead of CSV format

Additional Information

Typically people query all mods (i.e., pass null for userIds) or check for a single user ID, so this issue hadn't been noticed

@iProdigy iProdigy merged commit 7a03116 into develop Feb 19, 2024
@iProdigy iProdigy deleted the fix/helix-moderators-get-ids branch February 19, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants