Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve shadow jar building #961

Merged
merged 2 commits into from Apr 6, 2024
Merged

chore: improve shadow jar building #961

merged 2 commits into from Apr 6, 2024

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Apr 6, 2024

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Related Issues

Changes Proposed

  • Explicitly use Goooler's shadow plugin fork (for now)
  • Exclude module-info.class from jackson-core
  • Mark shadow jar as a multi-release jar (due to FastDoubleParser impls)

Additional Information

JDK 21+ classes were coming from jackson-core's multi-release jar - https://togithub.com/FasterXML/jackson-core/issues/1185

@iProdigy iProdigy merged commit a07a9fa into develop Apr 6, 2024
@iProdigy iProdigy deleted the chore/goooler-shadowjar branch April 6, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer PhilippHeuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iProdigy @PhilippHeuer