Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Http Reason Phrase to Avoid Unconscious Incompatibilities. #106

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

xinlifoobar
Copy link

@xinlifoobar xinlifoobar commented Mar 7, 2023

Some backend services (e.g., Azure Relay) are customizing HTTP reason phrases. This should be considered as misuse of the HTTP protocol but that info may need to be kept at the proxying time to keep the integrity of the origin messages.

An example response:

401 MissingToken: Relay security token is required. TrackingId:988e8147-c5ed-473c-a679-fb2c0d400ee4_G11, SystemTracker:hdirelay-uswe-d4c1893d-0.servicebus.windows.net:a21a0c87558b411bb098f8a8c7cad92a, Timestamp:2023-03-07T03:52:29

@xinlifoobar
Copy link
Author

xinlifoobar commented Mar 7, 2023

@twitchax please review this.

@xinlifoobar xinlifoobar changed the title Proxy Http Reason Phrase to Avoid Unconditional Incompatibilities. Proxy Http Reason Phrase to Avoid Unconscious Incompatibilities. Mar 7, 2023
@twitchax
Copy link
Owner

Hey, sorry, I was out of town, and missed this. Will take a look.

@twitchax twitchax merged commit b3f70af into twitchax:master Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants