-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update packaging for .net 5 #75
Conversation
Hell yeah: I've been meaning to do this. Any ideas what the build failure is? Looks like there is just some issue finding the tests? |
yeah, that was it exactly. I forgot the formatting of TargetFramework vs TargetFrameworks |
Just a bit more work on making the netcoreapp3.1 sdk availble as well, then this should be good to go. |
@baronfel, I'll be honest: I've been dabbling in a lot of Rust lately and have not kept up on the .NET 5 news as much as I normally would have. Do we still need to keep the |
Yep! Generally for a library like this I recommend:
|
3858fb1
to
da2c93b
Compare
How's rust working for you? I'm mostly an F# guy myself and so knowing that it exists makes me more comfortable working on systems programming :) |
There we go, green at last :) |
Rust is fantastic: I highly recommend it. :) |
This MR updates the packaging of this project (which is awesome, thanks by the way!) to support .net 5. There are no breaking API changes, it just means that we don't hit the old
netstandard2.0
pathway which drags in Aspnetcore dependencies that aren't the framework reference.