Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update packaging for .net 5 #75

Merged
merged 4 commits into from
Apr 13, 2021
Merged

Conversation

baronfel
Copy link
Contributor

This MR updates the packaging of this project (which is awesome, thanks by the way!) to support .net 5. There are no breaking API changes, it just means that we don't hit the old netstandard2.0 pathway which drags in Aspnetcore dependencies that aren't the framework reference.

@twitchax
Copy link
Owner

Hell yeah: I've been meaning to do this. Any ideas what the build failure is? Looks like there is just some issue finding the tests?

@baronfel
Copy link
Contributor Author

yeah, that was it exactly. I forgot the formatting of TargetFramework vs TargetFrameworks

@baronfel
Copy link
Contributor Author

Just a bit more work on making the netcoreapp3.1 sdk availble as well, then this should be good to go.

@twitchax
Copy link
Owner

@baronfel, I'll be honest: I've been dabbling in a lot of Rust lately and have not kept up on the .NET 5 news as much as I normally would have.

Do we still need to keep the netstandard2.0 targets around? Assuming yes for back compat?

@baronfel
Copy link
Contributor Author

Yep! Generally for a library like this I recommend:

  • netstandard2.0 - for .net framework 48+ folks
  • netcoreapp3.1 - for LTS support
  • net5 - for latest awesomeness

@baronfel
Copy link
Contributor Author

How's rust working for you? I'm mostly an F# guy myself and so knowing that it exists makes me more comfortable working on systems programming :)

@baronfel
Copy link
Contributor Author

There we go, green at last :)

@twitchax
Copy link
Owner

Rust is fantastic: I highly recommend it. :)

@twitchax twitchax merged commit 7219409 into twitchax:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants