Add example to route all unhandled requests #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dahlbyk
commented
Mar 16, 2022
dahlbyk
commented
- Is this a useful example?
- Is there a better way to do this?
|
@dahlbyk, ping here. :) |
|
👋 |
twitchax
requested changes
Jun 12, 2023
| var context = statusCodeContext.HttpContext; | ||
| if (context.Response.StatusCode == StatusCodes.Status404NotFound) | ||
| { | ||
| var request = context.Features.Get<IHttpRequestFeature>(); |
There was a problem hiding this comment.
Can you just use context.Request?
There was a problem hiding this comment.
It's possible to stitch back together approximately what the request path+query was from HttpRequest, but passing through RawTarget unaltered seems more correct from a proxy standpoint (e.g. it works for an OPTIONS * request)
Gets or sets the request target as it was sent in the HTTP request.
twitchax
approved these changes
Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.