Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIP boolean tag is inconsistent with mod and other "common" tags #668

Closed
BarryCarlyon opened this issue Oct 1, 2022 · 4 comments
Closed

Comments

@BarryCarlyon
Copy link
Contributor

BarryCarlyon commented Oct 1, 2022

Brief description

VIP tag do not appear with =0 only =1

This is inconsistent with the mod tag for example

"Common" tags = tags usually sent with most normal chat messages.

How to reproduce

Observe a vip, and non VIP messages

Expected behavior

Not sure

Additional context or questions

https://discuss.dev.twitch.tv/t/boolean-privmsg-tags-should-not-be-included-if-they-are-false-0/40992

@pajlada
Copy link

pajlada commented Oct 1, 2022

As a reference, the documentation for the tags can be found here: https://dev.twitch.tv/docs/irc/tags#privmsg-tags

The wording for the three boolean tags are

VIP

A Boolean value that determines whether the user that sent the chat is a VIP. The message includes this tag if the user is a VIP; otherwise, the message doesn’t include this tag (check for the presence of the tag instead of whether the tag is set to true or false).

Moderator

A Boolean value that determines whether the user is a moderator. Is true (1) if the user is a moderator; otherwise, false (0).

Subscriber

A Boolean value that determines whether the user is a subscriber. Is true (1) if the user is a subscriber; otherwise, false (0).

All three documented values are fairly strongly worded.

The subscriber tag does actually show up with a 0 value if a user is not subscribed as opposed to the initial issue text
Non-subscriber: @badge-info=;badges=;color=#696969;display-name=NotKarar;emotes=;first-msg=0;flags=;id=9f42e36e-b167-4d67-b3f2-255830b8b876;mod=0;returning-chatter=0;room-id=11148817;subscriber=0;tmi-sent-ts=1664629239130;turbo=0;user-id=89954186;user-type= :notkarar!notkarar@notkarar.tmi.twitch.tv PRIVMSG #pajlada :-tags
Subscriber: @badge-info=subscriber/81;badges=broadcaster/1,subscriber/3072,partner/1;color=#CC44FF;display-name=pajlada;emotes=;first-msg=0;flags=;id=6689e12c-b61f-46c9-93a4-e40a93f9f64c;mod=0;returning-chatter=0;room-id=11148817;subscriber=1;tmi-sent-ts=1664629341640;turbo=0;user-id=11148817;user-type= :pajlada!pajlada@pajlada.tmi.twitch.tv PRIVMSG #pajlada :-tags

Non-VIP: @badge-info=subscriber/62;badges=subscriber/3060;color=#8A2BE2;display-name=테스트계정420;emotes=;first-msg=0;flags=;id=1e2b6e42-1343-4a66-883e-8ac778f02110;mod=0;returning-chatter=0;room-id=11148817;subscriber=1;tmi-sent-ts=1664629480527;turbo=0;user-id=117166826;user-type= :testaccount_420!testaccount_420@testaccount_420.tmi.twitch.tv PRIVMSG #pajlada :-tags
VIP: @badge-info=subscriber/62;badges=vip/1,subscriber/3060;color=#8A2BE2;display-name=테스트계정420;emotes=;first-msg=0;flags=;id=de40ce40-5b2b-4c8e-8be7-c81f50a9192b;mod=0;returning-chatter=0;room-id=11148817;subscriber=1;tmi-sent-ts=1664629463203;turbo=0;user-id=117166826;user-type=;vip=1 :testaccount_420!testaccount_420@testaccount_420.tmi.twitch.tv PRIVMSG #pajlada :-tags

Non-moderator: @badge-info=subscriber/62;badges=subscriber/3060;color=#8A2BE2;display-name=테스트계정420;emotes=;first-msg=0;flags=;id=89a457dd-093d-4033-81e1-f5883829d113;mod=0;returning-chatter=0;room-id=11148817;subscriber=1;tmi-sent-ts=1664629537825;turbo=0;user-id=117166826;user-type= :testaccount_420!testaccount_420@testaccount_420.tmi.twitch.tv PRIVMSG #pajlada :-tags
Moderator: @badge-info=subscriber/62;badges=moderator/1,subscriber/3060;color=#8A2BE2;display-name=테스트계정420;emotes=;first-msg=0;flags=;id=5ee08b29-59e2-494b-800c-795bdb0dea66;mod=1;returning-chatter=0;room-id=11148817;subscriber=1;tmi-sent-ts=1664629514778;turbo=0;user-id=117166826;user-type=mod :testaccount_420!testaccount_420@testaccount_420.tmi.twitch.tv PRIVMSG #pajlada :-tags

@BarryCarlyon
Copy link
Contributor Author

BarryCarlyon commented Oct 1, 2022

The subscriber tag does actually show up with a 0 value if a user is not subscribed as opposed to the initial issue text

In a quick skim of some raw logs I didn't see it. So I jsut missed it whilst quick skimming some logs. Since thats what I thought it did anyway (I bet I hit a usernotice or something whislt tag skimming)

Revised the OP. Was a quick issue bash off the back of a forum post

@BarryCarlyon BarryCarlyon changed the title VIP (and subscriber) boolean tag is inconsistent with mod and other "common" tags VIP boolean tag is inconsistent with mod and other "common" tags Oct 1, 2022
@Felanbird
Copy link

Expected behavior
Not sure

This approach to the VIP tag seems more correct than the prior implementations, I have this feeling the only reason they don't update the former implementations is they've been around too long and changing it will effect way too much code 3p code (and probably some 1p).

@BarryCarlyon
Copy link
Contributor Author

Closing since if forum op really things it's a issue they can user voice it

@BarryCarlyon BarryCarlyon closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants