Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing test errors #273

Merged
merged 3 commits into from Sep 12, 2023
Merged

Fixing test errors #273

merged 3 commits into from Sep 12, 2023

Conversation

Xemdo
Copy link
Contributor

@Xemdo Xemdo commented Sep 12, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

  • Tests weren't always working in WSL due to database connection issues
  • Sometimes on /internal/login tests the HTTP server would hang

Description of Changes:

  • Fixed both of these issues

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@Xemdo Xemdo merged commit 100d3b0 into main Sep 12, 2023
8 checks passed
@Xemdo Xemdo deleted the fixing-test-errors branch September 12, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Xemdo