Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event configure command #299

Merged
merged 2 commits into from Dec 13, 2023
Merged

event configure command #299

merged 2 commits into from Dec 13, 2023

Conversation

lleadbet
Copy link
Collaborator

@lleadbet lleadbet commented Dec 3, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

Adds a new twitch event configure command as noted by @BarryCarlyon in #96.

Description of Changes:

  • Adds new command
  • Updated test harness to add a new temporary environment variable to allow for easier overriding of the viper configuration path

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@lleadbet lleadbet requested a review from Xemdo December 3, 2023 22:18
@Xemdo
Copy link
Contributor

Xemdo commented Dec 13, 2023

Changes have been made to cmd/events.go after you submitted this PR.
Can you check over the conflicts to see how it should be resolved?

@lleadbet
Copy link
Collaborator Author

@Xemdo - done

@Xemdo Xemdo linked an issue Dec 13, 2023 that may be closed by this pull request
@Xemdo Xemdo merged commit bca3aec into main Dec 13, 2023
8 checks passed
@Xemdo Xemdo deleted the feat/eventsub-configure branch December 13, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Configure for EventSub Defaults
2 participants