Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moderator change events on WebSub #41

Merged
merged 3 commits into from
Mar 8, 2021
Merged

Moderator change events on WebSub #41

merged 3 commits into from
Mar 8, 2021

Conversation

vpolouchkine
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

Adds WebSub Moderator Change events.

Description of Changes:

  • twitch event trigger add-moderator -T websub that maps to the moderation.moderator.add event
  • twitch event trigger remove-moderator -T websub that maps to the moderation.moderator.remove event

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

lleadbet
lleadbet approved these changes Mar 8, 2021
View reviewed changes
Copy link
Collaborator

@lleadbet lleadbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One comment, otherwise :shipit:

internal/events/types/moderator_change/moderator_change_event.go

var transportsSupported = map[string]bool{
models.TransportWebSub: true,
models.TransportEventSub: false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://dev.twitch.tv/docs/eventsub/eventsub-subscription-types#channelmoderatoradd-beta <- may be worth adding beta support?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will open a separate PR

@vpolouchkine vpolouchkine merged commit a92cdfe into main Mar 8, 2021
@lleadbet lleadbet deleted the moderator-add-remove branch March 10, 2021 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lleadbet lleadbet lleadbet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vpolouchkine @lleadbet